From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 17 Apr 2015 16:21:31 GMT
Subject: Re: [PATCH v8 1/4] sha1_file.c: support reading from a loose object of unknown type
Message-ID: <xmqqd232hgj8.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20150417142310.GA12479@peff.net>

Jeff King <peff@peff.net> writes:

> If there _is_ a performance implication to worry about here, I think it
> would be that we are doing an extra malloc/free.

Thanks for reminding me; yes, that also worried me.

> I'm not sure I
> understand why we are copying it at all. The original code copied from
> the hdr into type[10] so that we could NUL-terminate it, which was
> required for type_from_string().

Sounds like a good plan.

>
> But now we use type_from_string_gently, which can accept a length[1]. So
> we could just count the bytes to the first space and pass the original
> buffer along with that length, no?
>
> -Peff
>
> [1] Not related to your patch, but it looks like type_from_string_gently
>     is overly lax. It does a strncmp() with the length of the candidate
>     name, but does not check that we consumed all of the matching name.
>     So "tr" would match "tree", "comm" would match "commit", and so
>     forth.