From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 31 Aug 2015 17:56:52 GMT
Subject: Re: [PATCH v6 1/2] worktree: add 'for_each_worktree' function
Message-ID: <xmqqd1y3wdcr.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAPig+cTHZrQn8LpfftcsAQhFAykgDorbR97tkcuSCFYD_ngs9g@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

> Thanks for working on this....

<aol>metoo</aol>

> Stepping back a bit, is a for-each-foo()-style interface desirable?
> This sort of interface imposes a good deal of complexity on callers,
> demanding a callback function and callback data (cb_data), and is
> generally (at least in C) more difficult to reason about than other
> simpler interfaces. Is such complexity warranted?
>
> An alternate, much simpler interface would be to have a function, say
> get_worktrees(), return an array of 'worktree' structures to the
> caller, which the caller would iterate over (which is a common
> operation in C, thus easily reasoned about).

Nice.