From: Junio C Hamano Date: Tue, 08 Sep 2015 18:20:25 GMT Subject: Re: [PATCH v16 00/14] port tag.c to use ref-filter APIs Message-ID: In-Reply-To: Matthieu Moy writes: >>> This line still looks overlong. Would it help to stop spelling this >>> as a double "a = b = overlong expression" assignment? >>> >> >> I'm not sure, I get what you mean. > > I guess > > format = xstrfmt("%%(align:15,left)%%(refname:short)%%(end) %%(contents:lines=%d)", > filter->lines); > to_free = format; > > (still 83 columns + indentation, but that's a bit shorter than your > version). Sure. This may also be possible xstrfmt("%s %%(contents:lines=%d)", "%(align:15,left)%(refname:short)%(end)", filter->lines); and highlights that the only thing that is variable is the number of lines, which might be better.