From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 18 Mar 2016 21:44:10 GMT
Subject: Re: [PATCHv3 1/2] rebase: decouple --exec from --interactive
Message-ID: <xmqqd1qrpil1.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <xmqqh9g3pj3e.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

>>         +	EDITOR="echo >invoked_editor" git rebase --exec "echo a line >>exec_output"  HEAD~2 2>actual &&
>
> Hmph.  If you add "-i" to the command line, do you see the
> 'invoked_editor' file created?
>
> I ask this because I thought we override GIT_EDITOR, which has
> higher precedence than EDITOR, in the test-lib framework.

False alarm.  We do use EDITOR=: and arrange GIT_EDITOR from the
outside world to be ignored by unsetting in test-lib.sh, so
exporting EDITOR here should be safe and OK.

Will queue once I manage to locate 2/2 ;-).