From: Junio C Hamano Date: Mon, 06 Jun 2016 18:10:48 GMT Subject: Re: [PATCH] regex: fix a SIZE_MAX macro redefinition warning Message-ID: In-Reply-To: <57542A85.3040206@ramsayjones.plus.com> Ramsay Jones writes: > The original version of this patch looked like this: > ... > So, just move the unconditional inclusion to the start of the compilation > unit root file, before the #include of the regex_internal.h header. > > In some ways this is a better fix, because it makes it clear that, currently, > the compat/regex code requires . This would remove the need for > such a comment. Sounds sensible to me too.