From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 26 Jul 2016 06:46:07 GMT
Subject: Re: [PATCH 1/3] t7900-subtree.sh: fix quoting and broken && chains
Message-ID: <xmqqd1m03nio.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAPig+cRGz2eqPK0uaih3hYCV0eLayot3VGyjKaz5Qf8Jy5o=DA@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

>> @@ -73,10 +73,10 @@ join_commits()
>>  test_create_commit() (
>>         repo=$1
>>         commit=$2
>
> Perhaps &&-chain the above two lines also to future-proof against
> someone inserting important code somewhere above the following 'cd'.

Yup, also we can have them on a single line, i.e.

	repo=$1 commit=$2 &&
	cd "$repo" &&
        ...

Thanks

>
>> -       cd "$repo"
>> -       mkdir -p $(dirname "$commit") \
>> +       cd "$repo" &&
>> +       mkdir -p "$(dirname "$commit")" \
>>         || error "Could not create directory for commit"
>> -       echo "$commit" >"$commit"
>> +       echo "$commit" >"$commit" &&
>>         git add "$commit" || error "Could not add commit"
>>         git commit -m "$commit" || error "Could not commit"
>>  )