From: Junio C Hamano Date: Wed, 10 Aug 2016 21:14:22 GMT Subject: Re: patch submission process, was Re: [PATCH v6 06/16] merge_recursive: abort properly upon errors Message-ID: In-Reply-To: <20160810193057.s36wfcivlfm3xmh2@x> Josh Triplett writes: >> But submission is less important than review. And for review it is >> usually better (except gigantic series) to have patch text for review >> with the review. > > Agreed. However, submission typically requires more work than review, > because the patch text must remain applicable. For review, as long as > the email client you use to respond doesn't do something horrible like > *re-wrap* the quoted patch text, the result will work as a review. Yup. That is why we say "please send patch inline; when asked to send it as an attachment, please do so".