From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 14 Mar 2017 01:50:09 GMT
Subject: Re: [GSoC][PATCH/RFC v3 2/3] credential-cache: use XDG_CACHE_HOME for socket
Message-ID: <xmqqd1dklj8u.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170314003246.71586-3-lehmacdj@gmail.com>

Devin Lehmacher <lehmacdj@gmail.com> writes:

> Signed-off-by: Devin Lehmacher <lehmacdj@gmail.com>
> Reviewed-by: Junio C Hamano, Jeff King

The last line is premature; neither of us reviewed this exact
version and haven't checked if all the issues we mentioned in the
previous review have been addressed.


> +static char *get_socket_path(void) {

Compare ths line with how cmd_main() below is declared.  Notice
any difference?  We begin our functions like this:

	static char *get_socket_path(void)
	{