From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 27 Nov 2017 02:08:02 GMT
Subject: Re: [PATCH] grep: Add option --max-line-len
Message-ID: <xmqqd144fp8d.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAN+rsqnnFXxh4=mk8L5Hzk=f=rTU101XiO-GvepSXsaVePOkZQ@mail.gmail.com>

Marc-Antoine Ruel <maruel@chromium.org> writes:

> [second try, now with text format]
>
> Thanks a lot for the reviews. Replying to both.
>
> If I send a follow up, I'll fix the commit description and the help
> string, remove the shorthand -M, write a more sensible test.
>
> ...
>
> Thanks for the thoughtful analysis. My main motivation was (1), thus
> filtering with a pathspec is much better than trying to work around
> the issue. The issues raised in the review are significant enough that
> committing this patch could cause significant issues; I don't know how
> to resolve handling with -v and how to handle tabs.

OK.  Thanks for thinking it through.