From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 06 Dec 2017 18:47:29 GMT
Subject: Re: [PATCH v4 1/4] Makefile: generate Perl header from template file
Message-ID: <xmqqd13rhewu.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <e0a22ee4-9503-760f-293c-be56fa46fa04@kdbg.org>

Johannes Sixt <j6t@kdbg.org> writes:

> The updated series works for me now. Nevertheless, I suggest to squash
> in the following change to protect against IFS and globbing characters in
> $INSTLIBDIR.

Yeah, that is very sensible.

> diff --git a/Makefile b/Makefile
> index 7ac4458f11..08c78a1a63 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2072,7 +2072,7 @@ GIT-PERL-HEADER: $(PERL_HEADER_TEMPLATE) GIT-PERL-DEFINES perl/perl.mak Makefile
>  	INSTLIBDIR_EXTRA='$(PERLLIB_EXTRA_SQ)' && \
>  	INSTLIBDIR="$$INSTLIBDIR$${INSTLIBDIR_EXTRA:+:$$INSTLIBDIR_EXTRA}" && \
>  	sed -e 's=@@PATHSEP@@=$(pathsep)=g' \
> -	    -e 's=@@INSTLIBDIR@@='$$INSTLIBDIR'=g' \
> +	    -e 's=@@INSTLIBDIR@@='"$$INSTLIBDIR"'=g' \
>  	    -e 's=@@GITEXECDIR@@=$(gitexecdir_relative_SQ)=g' \
>  	    -e 's=@@PERLLIBDIR@@=$(perllibdir_relative_SQ)=g' \
>  	    $< >$@+ && \