From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 29 Mar 2018 20:40:19 GMT
Subject: Re: [PATCH v4] Allow use of TLS 1.3
Message-ID: <xmqqd0zm62fg.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180329101418.GA7736@voidlinux>

Loganaden Velvindron <logan@hackers.mu> writes:

> diff --git a/http.c b/http.c
> index a5bd5d62c..f84b18551 100644
> --- a/http.c
> +++ b/http.c
> @@ -62,6 +62,9 @@ static struct {
>  	{ "tlsv1.1", CURL_SSLVERSION_TLSv1_1 },
>  	{ "tlsv1.2", CURL_SSLVERSION_TLSv1_2 },
>  #endif
> +#if LIBCURL_VERSION_NUM >= 0x073400
> +	{ "tlsv1.3", CURL_SSLVERSION_TLSv1_3 }

Looks OK to me, except one minor nit.

I'll add a trailing comma for this entry while queuing, so that a
future patch to add tlsv1.4 or whatever won't have to worry about
it.

Thanks.

> +#endif
>  };
>  #if LIBCURL_VERSION_NUM >= 0x070903
>  static const char *ssl_key;