From: Junio C Hamano Date: Tue, 08 May 2018 01:07:54 GMT Subject: Re: [PATCH] alloc.c: replace alloc by mempool Message-ID: In-Reply-To: Stefan Beller writes: > The replacement with mem-pool might be easier than making sure > that alloc.c has no globals and handles allocations per repository > correctly. It would make the sb/object-store-alloc series shorter than > it currently is, and maybe easier to review the code. > > However now that sb/object-store-alloc is rerolled with keeping > the logic of alloc.c and not replacing it with mem-pool, the only > reason would be ease of maintainability by less code That is sensible considertation; the patch should be sold as such, instead of with an empty log message as if the reasoning is obvious to everybody without being told ;-)