From: Junio C Hamano Date: Thu, 21 Feb 2019 17:38:05 GMT Subject: Re: [PATCH v2] protocol-capabilities.txt: document symref Message-ID: In-Reply-To: <20190220003248.GA160251@google.com> Josh Steadmon writes: > On 2019.02.13 22:56, Jeff King wrote: > ... >> may say "...and you can use capabilities from protocol-capabilities.txt >> here". But it doesn't. It newly lists the capabilities, which makes this >> paragraph the right thing to say. >> >> It does mean that if we teach v1 a new capability, we'll have to >> document it in both places. But moving forward, we'd hopefully not be >> doing that too often (I haven't seen talk of flipping the v2 switch yet >> by default, but obviously that's where we want to end up). Yes. >> I probably would have put this in its own patch, but barring that we >> should probably at least mention in the commit message what this >> paragraph is doing here. >> >> -Peff > > Done in V3. Thanks! Will replace (easy to do as nothing is moving to 'next', unless it is for the upcoming release, during the freeze anyway ;-) Thanks.