From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 25 Mar 2020 21:24:37 GMT
Subject: Re: [PATCH] added: Multi line support for ignore-paths configuration
Message-ID: <xmqqd090w2ju.fsf@gitster.c.googlers.com>
In-Reply-To: <20200325203823.GA21913@dcvr>

Eric Wong <e@80x24.org> writes:

> Lukas Pupka-Lipinski <lukas.pupkalipinski@lpl-mind.de> wrote:
>> From 01d4e4dbc4e524db6188f41904a7274d1582d066 Mon Sep 17 00:00:00 2001
>
> Hello Lukas and welcome to git hacker community!  It looks like
> your first patch, so some details to point out, most of which
> should be covered in `Documentation/SubmittingPatches'

Thanks, Lukas and Eric for an excellent review.

 Thanks, though S-o-b generally includes the full name, so:
>
>   Signed-off-by: Lukas Pupka-Lipinski <lukas.pupkalipinski@lpl-mind.de>
>
> is more appropriate

Yes.  The author identity and the "name <addr>" on Signed-off-by
line should match.