From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 08 Apr 2020 00:11:50 GMT
Subject: Re: [PATCH v5 05/22] sequencer: make read_oneliner() accept flags
Message-ID: <xmqqd08irg3d.fsf@gitster.c.googlers.com>
In-Reply-To: <f30ad07823c6e8f47c217ac24a06e02d3e0af554.1586269543.git.liu.denton@gmail.com>

Denton Liu <liu.denton@gmail.com> writes:

> In a future commit, we will need read_oneliner() to accept flags other
> than just `skip_if_empty`. Instead of having an argument for each flag,
> teach read_oneliner() to accept the bitfield `flags` instead. For now,
> only recognize the `READ_ONELINER_SKIP_IF_EMPTY` flag. More flags will
> be added in a future commit.

Good move.  Looked sensible.

Thanks.