From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 04 May 2020 21:05:16 GMT
Subject: Re: [PATCH 2/2] ref-filter: apply fallback refname sort only after all user sorts
Message-ID: <xmqqd07jfm2b.fsf@gitster.c.googlers.com>
In-Reply-To: <20200503091309.GB170902@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> Commit 9e468334b4 (ref-filter: fallback on alphabetical comparison,
> 2015-10-30) taught ref-filter's sort to fallback to comparing refnames.
> But it did it at the wrong level, overriding the comparison result for a
> single "--sort" key from the user, rather than after all sort keys have
> been exhausted.

Good find.  It does look like that the fallback was broken from the
very first version when it was introduced, as we did have multiple
keys support back in that version already.

The fix looks good to me.

Thanks.