From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 09 Aug 2020 19:01:35 GMT
Subject: Re: [RFC PATCH 0/2] extend --abbrev support to diff-patch format
Message-ID: <xmqqd03zej8w.fsf@gitster.c.googlers.com>
In-Reply-To: <cover.1596887883.git.congdanhqx@gmail.com>

Đoàn Trần Công Danh  <congdanhqx@gmail.com> writes:

> Đoàn Trần Công Danh (2):
>   revision: differentiate if --no-abbrev asked explicitly
>   diff: extend --abbrev support to diff-patch format

It was not clear, at least to me at all, what these patches are
trying to achieve (i.e. what end-users appreciate) until I saw the
code change X-<.

The changes to fill_metainfo() make sense to me.  It just needs log
messages that explain the intent better.  They do not even make it
clear that they want to make the abbreviation length of the object
names on the "index $from..$to $mode" lines configurable.

Thanks.