From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 12 Aug 2020 20:31:58 GMT
Subject: Re: [PATCH v2] midx: use buffered I/O to talk to pack-objects
Message-ID: <xmqqd03v61xd.fsf@gitster.c.googlers.com>
In-Reply-To: <xmqqh7t7623d.fsf@gitster.c.googlers.com>

Junio C Hamano <gitster@pobox.com> writes:

> René Scharfe <l.s.r@web.de> writes:
>
>>  		nth_midxed_object_oid(&oid, m, i);
>> -		xwrite(cmd.in, oid_to_hex(&oid), the_hash_algo->hexsz);
>> -		xwrite(cmd.in, "\n", 1);
>> +		fprintf(cmd_in, "%s\n", oid_to_hex(&oid));
>
> I do think it is silly to send an object name and terminating LF in
> two different system calls per object.
>
> The original uses xwrite() so that it does not have to worry about
> having to restart interrupted system calls and such.

Oops.  There is not much in "and such".  xwrite() only restarts but
the caller must deal with truncated write, which the original does
not do.