From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 23 Jan 2021 18:50:42 GMT
Subject: Re: [PATCH v2 7/8] test-lib: test_region looks for trace2 regions
Message-ID: <xmqqczxv4hdp.fsf@gitster.c.googlers.com>
In-Reply-To: <8406512b-3d9f-e899-24fd-8a09c4af3569@gmail.com>

Derrick Stolee <stolee@gmail.com> writes:

>>> +	if test $exitcode != $expect_exit
>> 
>> ... this will not trigger and we return "success" (i.e. "failed as
>> expected")?
>
> Am I misunderstanding something here? If exitcode is 2, then this
> will always trigger and return 1, signaling a failure.

Are, please disregard.  Yes, the above does the right thing already.