From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 18 Feb 2022 20:26:10 GMT
Subject: Re: [PATCH 2/3] reflog: call reflog_delete from reflog.c
Message-ID: <xmqqczjjzztp.fsf@gitster.g>
In-Reply-To: <220218.86sfsggf0e.gmgdl@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

> Maybe others will disagree, but per my comment on 1/2 I found reviewing
> this locally much easier with this squashed into 1/2 (without the {}
> changes I suggested).

Oh, I am pretty much on the same page.

The if() block has to retain {} after all but not for the reason you
cite (i.e. help "diff --color-moved"), but for correctness reasons
it has to have some "early return to avoid using NULL" to replace
"continue", which means the body of the if() statement needs to stay
a two statement block.