From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 06 Mar 2023 22:24:02 GMT
Subject: Re: [PATCH 0/8] ahead-behind: new builtin for counting multiple commit ranges
Message-ID: <xmqqcz5l8qnx.fsf@gitster.g>
In-Reply-To: <8be01cb6-8937-faed-0850-4501a2f1ef55@github.com>

Derrick Stolee <derrickstolee@github.com> writes:

> 'git for-each-ref --merged' is probably sufficient. The only difference
> being that it would be nice to specify the matching refs over stdin
> with --stdin to avoid long argument lists.

Yeah, if you have a list of concrete refs maintained externally
(as opposed to the example I responded to, where you generate the
refs by telling for-each-ref what pattern they should match), having
--stdin would be a good thing.

> So, there is benefit in using this tips_reachable_from_base() method in
> the two existing 'git (branch|for-each-ref) --merged' computations. The
> API boundary selected in this series might not be the most appropriate
> for those builtins, so let's kick out patch 8 from this series for now
> and I'll revisit it separately.

Yup, if the reachability API refactoring in these patches can also
help the "for-each-ref" listing (which "git branch" and "git tag"
bases their listing behaviour), it would be very good.

Thanks.