From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 15 Jul 2024 14:44:03 GMT
Subject: Re: [PATCH v2 2/1] t-strvec: improve check_strvec() output
Message-ID: <xmqqcyne90lo.fsf@gitster.g>
In-Reply-To: <f2bcee2b-88fa-4dcd-8247-f68d842c6a4c@web.de>

René Scharfe <l.s.r@web.de> writes:

> The macro check_strvec calls the function check_strvec_loc(), which
> performs the actual checks.  They report the line number inside that
> function on error, which is not very helpful.  Before the previous
> patch half of them triggered an assertion that reported the caller's
> line number using a custom message, which was more useful, but a bit
> awkward.
> ...
> We can let check_strvec add the terminating NULL for us and remove it
> from callers, making it impossible to forget.  Leave that conversion for
> a future patch, though, since this reimplementation is already intrusive
> enough.
>
> Reported-by: Jeff King <peff@peff.net>
> Signed-off-by: René Scharfe <l.s.r@web.de>
> ---
> For next, on top of c6f35e529e t-strvec: use test_msg().

Thanks.