From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 30 Dec 2024 17:08:36 GMT
Subject: Re: [PATCH 1/5] test-lib: use individual lsan dir for --stress runs
Message-ID: <xmqqcyh9yu7f.fsf@gitster.g>
In-Reply-To: <20241230042401.GA113400@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> When storing output in test-results/, we usually give each numbered run
> in a --stress set its own output file. But we don't do that for storing
> LSan logs, so something like:
>
>   ./t0003-attributes.sh --stress
>
> will have many scripts simultaneously creating, writing to, and deleting
> the test-results/t0003-attributes.leak directory. This can cause logs
> from one run to be attributed to another, spurious failures when
> creation and deletion race, and so on.
>
> This has always been broken, but nobody noticed because it's rare to do
> a --stress run with LSan (since the point is for the code to run quickly
> many times in order to hit races). But if you're trying to find a race
> in the leak sanitizing code, it makes sense to use these together.

Makes sense.

> We can fix it by using $TEST_RESULTS_BASE, which already incorporates
> the stress job suffix.

Thanks.  Queued.