From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 23 Oct 2026 17:55:44 GMT
Subject: Re: [Outreachy PATCH v2] checkout: use Q_() for messages with counts
Message-ID: <xmqqcxt0713z.fsf@gitster.g>
In-Reply-To: <20261022004834.246892-1-tangajoris@gmail.com>

Tanga Joris <tangajoris@gmail.com> writes:

>  - Also converted "only one reference expected, %d given.",
>    as discussed by Tuomas in Mudi's thread.
>
> Interdiff against v1:
>   diff --git a/builtin/checkout.c b/builtin/checkout.c
>   index 49239f029f..91b7c52396 100644
>   --- a/builtin/checkout.c
>   +++ b/builtin/checkout.c
>   @@ -1491,7 +1491,9 @@ static int parse_branchname_arg(int argc, const char **argv,
>    	else if (dash_dash_pos == 1)
>    		has_dash_dash = 1; /* case (3) or (1) */
>    	else if (dash_dash_pos >= 2)
>   -		die(_("only one reference expected, %d given."), dash_dash_pos);
>   +		die(Q_("only one reference expected, %d given.",
>   +		       "only one reference expected, %d given.",
>   +		       dash_dash_pos), dash_dash_pos);
>    	opts->count_checkout_paths = !opts->quiet && !has_dash_dash;
>    
>    	if (!strcmp(arg, "-"))
>
>  builtin/checkout.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

Looks good to me.  Will queue.  Thanks.