From: Junio C Hamano Date: Tue, 27 Oct 2026 17:59:57 GMT Subject: Re: [Outreachy PATCH v2] t1402: test --no-allow-onelevel option precedence Message-ID: In-Reply-To: <20261027145451.8617-1-fiendora5@gmail.com> Fien Dora writes: > Unlike most Git commands that use the parse_options() API, > check-ref-format relies on a handcrafted loop to parse command-line > options. Although the --no- prefix is commonly used to negate options > in Git, the precedence of --allow-onelevel and --no-allow-onelevel > is not explicitly covered by the existing tests. > > Add regression tests for both orders of --allow-onelevel and > --no-allow-onelevel to verify that the last option takes precedence. > The tests confirm that --no-allow-onelevel overrides a preceding > --allow-onelevel, and that --allow-onelevel similarly overrides a > preceding --no-allow-onelevel. Nicely described. > Git's planned work to improve argument parsing includes replacing > suitable handcrafted parsers with existing APIs. I haven't heard of anybody planning to do such a conversion, but do you mean you are planning to do such a work as a follow-up? If so, write it more like "I plan to do X in a separate series". If not, please do not make up hallucinated facts. > Signed-off-by: Fien Dora > --- > > t/t1402-check-ref-format.sh | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/t/t1402-check-ref-format.sh b/t/t1402-check-ref-format.sh > index 9dd64662b2..6036df0210 100755 > --- a/t/t1402-check-ref-format.sh > +++ b/t/t1402-check-ref-format.sh > @@ -74,6 +74,8 @@ invalid_ref 'heads/foo*/bar*' --refspec-pattern > ref='foo' > invalid_ref "$ref" > valid_ref "$ref" --allow-onelevel > +invalid_ref "$ref" '--allow-onelevel --no-allow-onelevel' > +valid_ref "$ref" '--no-allow-onelevel --allow-onelevel' > invalid_ref "$ref" --refspec-pattern > valid_ref "$ref" '--refspec-pattern --allow-onelevel' > invalid_ref "$ref" --normalize