From: Junio C Hamano Date: Wed, 02 Apr 2014 17:16:12 GMT Subject: Re: [PATCH 14/22] lockfile: use strbufs when handling (most) paths Message-ID: In-Reply-To: <1396367910-7299-15-git-send-email-mhagger@alum.mit.edu> Michael Haggerty writes: > Change struct lock_file's filename field from a fixed-length buffer > into a strbuf. Good. As I allued to in a review on an unrelated patch, I do not think it is a good idea to name the lock filename field "lock_filename" in a structure that is about a lockfile, though.