From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 17 Apr 2014 18:25:29 GMT
Subject: Re: [PATCH 001/14] howto-index.sh: use the $( ... ) construct for command substitution
Message-ID: <xmqqbnvzerty.fsf@gitster.dls.corp.google.com>
In-Reply-To: <vpqsipc1gah.fsf@anie.imag.fr>

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

> Elia Pinto <gitter.spiros@gmail.com> writes:
>
>> The Git CodingGuidelines prefer the $(...) construct for command
>> substitution instead of using the backquotes `...`.
>
> For patches 1 to 14:
>
> Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>
>
> (reviewed the patches in my mailer, and the "diff --color-words=." after
> applying in addition)

Thanks both.

Ideally, we should keep these scripted Porcelain implementations in
the contrib/examples/ hierarchy up-to-date to still work with the
recent versions of Git as they used to.  We do not need to backport
new features, but they should follow the best-current-practice of
the use of plumbing features and scripting in general, and this
update is probably a step in the right direction.  It is somewhat
sad that these are not tested but I do not think of an unintrusive
easy way to keep them also in the test suite.

Will queue.