From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 25 Mar 2015 17:29:41 GMT
Subject: Re: [PATCH 0/8] more &&-chaining test fixups
Message-ID: <xmqqbnjh2dfe.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20150325052456.GA19394@peff.net>

Jeff King <peff@peff.net> writes:

> There were a few legitimate problems, though. I've ordered the patches
> below by descending severity. These apply on top of jk/test-chain-lint.
>
>   [1/8]: perf-lib: fix ignored exit code inside loop
>   [2/8]: t0020: fix ignored exit code inside loops
>   [3/8]: t3305: fix ignored exit code inside loop
>   [4/8]: t7701: fix ignored exit code inside loop
>
>     These four are actual bugs.
>
>   [5/8]: t: fix some trivial cases of ignored exit codes in loops
>
>     These ones are in setup code, and so would almost certainly never
>     fail.
>
>   [6/8]: t: simplify loop exit-code status variables
>   [7/8]: t0020: use test_* helpers instead of hand-rolled messages
>   [8/8]: t9001: drop save_confirm helper
>
>     These last three are pure cleanup, no behavior changes. The last two
>     are not even strictly related to the same topic, but I noticed them
>     while in the area.

Thanks.  All looked sensible.