From: Junio C Hamano Date: Mon, 22 Jun 2015 22:08:09 GMT Subject: Re: [PATCH 2/2] Move unsigned long option parsing out of pack-objects.c Message-ID: In-Reply-To: <1434911144-6781-3-git-send-email-charles@hashpling.org> Charles Bailey writes: > From: Charles Bailey > > The unsigned long option parsing (including 'k'/'m'/'g' suffix parsing) > is more widely applicable. Add support for OPT_MAGNITUDE to > parse-options.h and change pack-objects.c use this support. > > The error behavior on parse errors follows that of OPT_INTEGER. > The name of the option that failed to parse is reported with a brief > message describing the expect format for the option argument and then > the full usage message for the command invoked. > > This is differs from the previous behavior for OPT_ULONG used in s/is //; (locally fixed--no need to resend).