From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 05 Oct 2015 21:00:03 GMT
Subject: Re: [PATCH v2 4/4] clone --dissociate: avoid locking pack files
Message-ID: <xmqqbncdxc8c.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <73315ceddd3ee6aa7d1c2f01bd1b64441b42ad22.1444076827.git.johannes.schindelin@gmx.de>

Johannes Schindelin <johannes.schindelin@gmx.de> writes:

> diff --git a/builtin/clone.c b/builtin/clone.c
> index 578da85..cc896e2 100644
> --- a/builtin/clone.c
> +++ b/builtin/clone.c
> @@ -1064,8 +1064,10 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
>  	transport_unlock_pack(transport);
>  	transport_disconnect(transport);
>  
> -	if (option_dissociate)
> +	if (option_dissociate) {
> +		close_all_packs();
>  		dissociate_from_references();
> +	}

Much simpler and looks very good.