From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 20 Jan 2016 01:51:58 GMT
Subject: Re: [PATCH] filter-branch: resolve $commit^{tree} in no-index case
Message-ID: <xmqqbn8h6mrl.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160120013436.GA24541@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

>> Mph.  We could get the best of both worlds by introducing a "git
>> rev-parse --compare <a> <b>" that compares object ids.  Actually...
>> 
>> How about something like this?
>
> Thanks. I had in my head that we could do something like that, but
> hadn't quite worked it out. I think what you wrote works.

But wouldn't "diff-tree --quiet" essentially be that command?

> If you want to wrap it up into a patch, I'd be OK with it, but note that
> it still falls afoul of changing $tree in a user-visible way (so you
> should note that in the commit message).

Yes, I think we should take your conservative variant for that exact
reason.