From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 21 Jan 2016 21:06:18 GMT
Subject: Re: [PATCH] unpack-trees: fix accidentally quadratic behavior
Message-ID: <xmqqbn8ey75h.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1453409984.16226.46.camel@twopensource.com>

David Turner <dturner@twopensource.com> writes:

>> The first break is correct, but I am not sure about the "else if"
>> part.  Shouldn't it be doing something similar to the logic to "keep
>> looking" that talks about "t-i", "t" and "t/a" at the end of the
>> loop?
>
> Rather than doing more complicated logic, let's just do the first
> check; it seems about as fast for our repo, and I think will usually be
> so.  does that seem reasonable to you?

Very reasonable.  I was mostly afraid of leaving the loop
prematurely and giving a wrong answer to the caller.