From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 25 Feb 2016 23:16:55 GMT
Subject: Re: [PATCH v3 1/2] t/lib-http/apache.conf: load mod_unixd module in apache 2.4
Message-ID: <xmqqbn74mlco.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160225220045.GA10267@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Thu, Feb 25, 2016 at 10:57:11AM -0800, Jacob Keller wrote:
>
>> From: Jacob Keller <jacob.keller@gmail.com>
>> 
>> Since 2.4, apache will fail to load unless mod_unixd is loaded in order
>> to drop privileges.
>> 
>> Signed-off-by: Jacob Keller <jacob.keller@gmail.com>
>> ---
>> 
>> I am not sure why this wasn't there already, but I am unable to run
>> httpd 2.4.18 without it, on Fedora 23.
>> 
>>  t/lib-httpd/apache.conf | 3 +++
>>  1 file changed, 3 insertions(+)
>
> Michael (cc'd) posted an identical patch with some more discussion back
> in May:
>
>   http://article.gmane.org/gmane.comp.version-control.git/268770
>
> The series languished because none of the reviewers had systems that
> reproduced the problem, and I think there's some additional work needed
> to get all of the svn-over-http tests running[1].
>
> I think this bit should be OK to take without the rest (though I like
> the extra discussion in the original).

I can resurrect 745a5487 (t/lib-httpd: load mod_unixd, 2015-04-08),
which is still on 'pu', and apply 2/2 from Jacov on top of it.

Thanks.

>
> -Peff
>
> [1] http://article.gmane.org/gmane.comp.version-control.git/284349