From: Junio C Hamano Date: Wed, 08 Jun 2016 19:31:11 GMT Subject: Re: [PATCH v4 4/6] send-email: create email parser subroutine Message-ID: In-Reply-To: <116d56ee-afdf-b1f2-f141-7449e6503f30@grenoble-inp.org> Samuel GROOT writes: > I think it's the best way to do it indeed. Furthermore, we did trim > CRs and LFs in header fields, but not in the message, making the > subroutine inconsistent. > > Should we rename the subroutine to `parse_header` or leave it as it is? If it lives inside git-send-email, then parse_header is sufficient as everybody would know it is about e-mail without being told. If it is in Git.pm, then parse_email_header would be more appropriate.