From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 03 Mar 2017 18:51:57 GMT
Subject: Re: [PATCH] t/perf: export variable used in other blocks
Message-ID: <xmqqbmti9os2.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170303064512.khs2seru5onl54mh@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> Thanks, this is obviously the right thing to do, and the mistake is mine
> from ea97002fc (t/perf: time rev-list with UNINTERESTING commits,
> 2014-01-20). This is not the first time I've been confused by missing
> variables in t/perf scripts, since it behaves differently than the
> normal test suite. I wonder if we should turn on "set -a" during t/perf
> setup snippets. That's a bit of a blunt tool, but I suspect it would
> just be easier to work with.

I wonder if we can make t/perf to behave more similar to the normal
test suite to eliminate the need for this exporting, by the way.
t/perf/README does not say anything more than "for lack of better
options" throughout its history, which does not help very much.