From: Junio C Hamano Date: Fri, 29 Sep 2017 02:13:49 GMT Subject: Re: [PATCH v3 00/21] Read `packed-refs` using mmap() Message-ID: In-Reply-To: <20170925122221.ntbhwvmyvgm4igxk@sigill.intra.peff.net> Jeff King writes: > On Mon, Sep 25, 2017 at 09:59:57AM +0200, Michael Haggerty wrote: > >> This is v3 of a patch series that changes the reading and caching of >> the `packed-refs` file to use `mmap()`. Thanks to Stefan, Peff, Dscho, >> and Junio for their comments about v2. I think I have addressed all of >> the feedback from v1 [1] and v2 [2]. >> >> This version has only minor changes relative to v2: >> >> * Fixed a trivial error in the commit message for patch 08. >> >> * In patch 13: >> >> * In the commit message, explain the appearance of `MMAP_TEMPORARY` >> even though it is not yet treated differently than `MMAP_NONE`. >> >> * In `Makefile`, don't make `USE_WIN32_MMAP` imply >> `MMAP_PREVENTS_DELETE`. >> >> * Correct the type of a local variable from `size_t` to `ssize_t`. > > Thanks, this version addresses all my nits. Dscho's "does not seem to break windows" was against the previous round, but it seems that https://travis-ci.org/git/git/jobs/280305212 passed the iteration of 'pu' at 044a672 which contained this version, so let's merge this down to 'next'. Thanks.