From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 17 May 2018 01:36:46 GMT
Subject: Re: [PATCH] grep: handle corrupt index files early
Message-ID: <xmqqbmdf6p1t.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CACsJy8A8WZ-Gqe2Y-whJmbADrt+gZjLZ7MTwCtdnK7JDnEdtog@mail.gmail.com>

Duy Nguyen <pclouds@gmail.com> writes:

> With a majority of call sites dying like this though, I wonder if we
> should just add repo_read_index_or_die() with die() inside. Then the
> next person won't likely accidentally forget _()

Yuck.

That sounds like inviting a major code churn.  I tend to agree that
it would be a good clean-up for longer term maintenance, but I am
not sure if I can honestly say I'd look forward to such a clean-up
at this point in the cycle when there are tons of large-ish topics
in flight X-<.