From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 22 Apr 2020 17:18:44 GMT
Subject: Re: [PATCH] config.mak.uname: Define FREAD_READS_DIRECTORIES for GNU/Hurd
Message-ID: <xmqqblnjjv63.fsf@gitster.c.googlers.com>
In-Reply-To: <20200422153347.40018-1-jrtc27@jrtc27.com>

Jessica Clarke <jrtc27@jrtc27.com> writes:

> GNU/Hurd is another platform that behaves like this. Set it to
> UnfortunatelyYes so that config directory files are correctly processed.
> This fixes the corresponding 'proper error on directory "files"' test in
> t1308-config-set.sh.
>
> Thanks-to: Jeff King <peff@peff.net>
> Signed-off-by: Jessica Clarke <jrtc27@jrtc27.com>
> ---
>  config.mak.uname | 1 +
>  1 file changed, 1 insertion(+)

I'd tweak s/Thanks-to:/Helped-by:/ while queuing.

Thanks for a quick turnaround after reporting the issue and getting
a response.  The way collaboration is working feels wonderful.



>
> diff --git a/config.mak.uname b/config.mak.uname
> index 0ab8e00938..3e526f6b9f 100644
> --- a/config.mak.uname
> +++ b/config.mak.uname
> @@ -308,6 +308,7 @@ ifeq ($(uname_S),GNU)
>  	NO_STRLCPY = YesPlease
>  	HAVE_PATHS_H = YesPlease
>  	LIBC_CONTAINS_LIBINTL = YesPlease
> +	FREAD_READS_DIRECTORIES = UnfortunatelyYes
>  endif
>  ifeq ($(uname_S),IRIX)
>  	NO_SETENV = YesPlease