From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 19 Jun 2020 16:35:53 GMT
Subject: Re: [PATCH v2 2/2] git-prompt: include sparsity state as well
Message-ID: <xmqqbllfj9na.fsf@gitster.c.googlers.com>
In-Reply-To: <xmqqftarj9qu.fsf@gitster.c.googlers.com>

Junio C Hamano <gitster@pobox.com> writes:

> SZEDER Gábor <szeder.dev@gmail.com> writes:
>
>>> +	local sparse=""
>>> +	if [ "$(git config --bool core.sparseCheckout)" == "true" ]; then
>>> +	    sparse="|SPARSE"
>>
>> Nit: indentation.
>
> Also, do we want "==" there?  I thought [ ... ] (unlike [[ ... ]])
> was a mere synonym for "test", to which "==" is a bug.

Ah, OK, this script is very bash specific so POSIX portability rules
do not matter.  == is just fine as = there.

Sorry for the noise.