From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 25 Jul 2020 23:03:38 GMT
Subject: Re: [PATCH v5 02/13] bisect--helper: use '-res' in 'cmd_bisect__helper' return
Message-ID: <xmqqblk3i4dx.fsf@gitster.c.googlers.com>
In-Reply-To: <20200725173118.GA614724@konoha>

Shourya Shukla <shouryashukla.oo@gmail.com> writes:

>> Following 'enum bisect_error' vocabulary, return variable 'res' is
>> always non-positive.
>> Let's use '-res' instead of 'abs(res)' to make the code clearer.
>
>> Mentored-by: Christian Couder <chriscool@tuxfamily.org>
>> Signed-off-by: Miriam Rubio <mirucam@gmail.com>
>> Helped-by: Junio C Hamano <gitster@pobox.com>
>
> Although there is no set rule for this, but I think that your sign-off
> goes at the last generally. This is what I have seen on various patches.

It is most natural to list these entries in chronological order.

Code was written while others helped, and the final seal on what
gets sent out is stamped by appending the author's sign-off at the
end.

Thanks.