From: Junio C Hamano Date: Fri, 30 Oct 2020 22:02:04 GMT Subject: Re: [PATCH v3 09/19] entry: add checkout_entry_ca() which takes preloaded conv_attrs Message-ID: In-Reply-To: Matheus Tavares writes: > The parallel checkout machinery will call checkout_entry() for entries > that could not be written in parallel due to path collisions. At this > point, we will already be holding the conversion attributes for each > entry, and it would be wasteful to let checkout_entry() load these > again. Instead, let's add the checkout_entry_ca() variant, which > optionally takes a preloaded conv_attrs struct. > > Signed-off-by: Matheus Tavares > --- I think my review comment to 08/19 is partly taken care of with this step. Perhaps the progression will become simpler to understand if we add this new helper first? I dunno. In either case, the end result of applying both 08 and 09 looks quite nicer than the state after up to 07 are applied.