From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 29 Jan 2021 07:49:13 GMT
Subject: Re: [PATCH 2/6] Makefile: guard against TEST_OBJS in the environment
Message-ID: <xmqqbld8tc7a.fsf@gitster.c.googlers.com>
In-Reply-To: <20210128182310.26787-3-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> Add TEST_OBJS to the list of other *_OBJS variables we reset. We had
> already established this pattern when TEST_OBJS was introduced in
> daa99a91729 (Makefile: make sure test helpers are rebuilt when headers
> change, 2010-01-26), but it wasn't added to the list in that commit
> along with the rest.
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
>  Makefile | 1 +
>  1 file changed, 1 insertion(+)

Makes sense.  I have only seen [1&2/6], and so far these look good.
Hopefully I'll see [3-6/6] as well.

> diff --git a/Makefile b/Makefile
> index 65e600713c1..63fa5c30b45 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -591,6 +591,7 @@ SCRIPT_PYTHON =
>  SCRIPT_SH =
>  SCRIPT_LIB =
>  TEST_BUILTINS_OBJS =
> +TEST_OBJS = 
>  TEST_PROGRAMS_NEED_X =
>  THIRD_PARTY_SOURCES =