From: Junio C Hamano Date: Wed, 21 Jul 2021 23:17:53 GMT Subject: Re: [PATCH v2 4/5] http: drop support for curl < 7.19.3 and < 7.16.4 (again) Message-ID: In-Reply-To: Ævar Arnfjörð Bjarmason writes: > Remove the conditional use of CURLAUTH_DIGEST_IE and > CURLOPT_USE_SSL. These two have been split from earlier simpler checks > against LIBCURL_VERSION_NUM for ease of review. > > The CURLAUTH_DIGEST_IE flag was added in n 7.19.3[1], and > CURLOPT_USE_SSL in 7.16.4[2], as noted in [2] it was then renamed from > the older CURLOPT_FTP_SSL. > > 1. https://curl.se/libcurl/c/CURLOPT_HTTPAUTH.html > 2. https://curl.se/libcurl/c/CURLOPT_USE_SSL.html My go-to place for cURL version information is: https://github.com/curl/curl/blob/master/docs/libcurl/symbols-in-versions and it says CURLOPT_USE_SSL has been available since 7.17.0. If 7.16.4 was the last version in the 7.16.x series, then these two sources are consistent. [2] says that the feature was available under a different name in the past and up to version 7.16.4, meaning with 7.16.4, USE_SSL was not usable. You'd need to do "<= 7.16.4" on the title, but it is simpler to follow the symbols-in-versions table and say "< 7.17.0", I would think. The patch text looks OK.