From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 25 Sep 2023 18:57:57 GMT
Subject: Re: [PATCH v7 2/3] unit tests: add TAP unit test framework
Message-ID: <xmqqbkdqt70q.fsf@gitster.g>
In-Reply-To: <0b6de919-8dbf-454f-807b-5abb64388cb7@gmail.com>

phillip.wood123@gmail.com writes:

> When I was writing this I was torn between whether to follow our usual
> convention of returning zero for success and minus one for failure or
> to return one for success and zero for failure. In the end I decided
> to go with the former but I tend to agree with you that the latter
> would be easier to understand.

An understandable contention.

>>>> @@ -0,0 +1,2 @@
>>>> +/t-basic
>>>> +/t-strbuf
>>>
>>> Also, can we come up with some naming convention so that we do not
>>> have to keep adding to this file every time we add a new test
>>> script?
>
> Perhaps we should put the unit test binaries in a separate directory
> so we can just add that directory to .gitignore.

Yeah, if we can do that, that would help organizing these tests.

Thanks for working on this.