From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 18 Dec 2023 18:10:57 GMT
Subject: Re: [PATCH] Teach git apply to respect core.fileMode settings
Message-ID: <xmqqbkanfkjy.fsf@gitster.g>
In-Reply-To: <xmqqle9rfkvd.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

>> +test_expect_success FILEMODE 'ensure git apply respects core.fileMode' '

Forgot to point out the most important thing.

The code change in this patch is primarily about making the code
work better for folks without trustworthy filemode support.
Emulating what happens by setting core.fileMode to false on a
platform with capable filesystems may be a way to test the code, but
we should have a test specific to folks without FILEMODE
prerequisites and make sure it works well, no?

IOW, shouldn't we drom FILEMODE prerequisite from this test?  How
does it break on say Windows if this test is added without FILEMODE
prerequisite?