From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 22 Jan 2025 18:18:40 GMT
Subject: Re: [PATCH v2] trace2: prevent segfault on config collection where no value specified
Message-ID: <xmqqbjvyww3j.fsf@gitster.g>
In-Reply-To: <xmqqfrlawwd9.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
>>
>> This patch looks good to me!
>
> Thanks.  As I punted on reviewing the tgt_perf part, it is very good
> to see somebody else step in to look it over.
>
> Will queue.

The test part used broken indentation and also the use of
test_when_finished was careless, so I'll touch it up before queuing.

No need to resend.

Thanks.