From: Junio C Hamano Date: Tue, 20 May 2025 22:09:50 GMT Subject: Re: [PATCH] t: remove unexpected SANITIZE_LEAK variables Message-ID: In-Reply-To: Justin Tobler writes: > On 25/05/20 04:40PM, Karthik Nayak wrote: >> As of 1fc7ddf35b (test-lib: unconditionally enable leak checking, >> 2024-11-20), both the `GIT_TEST_PASSING_SANITIZE_LEAK` and >> `TEST_PASSES_SANITIZE_LEAK` variables no longer have any meaning, the >> leak checks are enabled by default. However, some newly added tests >> include them by mistake. Let's clean this up. > > Indeed, both `GIT_TEST_PASSING_SANITIZE_LEAK` and > `TEST_PASSES_SANITIZE_LEAK` appear not have any purpose anymore. > Removing all remaining instances where they appear makes sense and from > a quick search it looks like this patch got them all. So this looks good > to me. Thanks, both.