From: Junio C Hamano Date: Mon, 27 Oct 2025 20:58:29 GMT Subject: Re: [PATCH v4 00/10] builtin/maintenance: introduce "geometric" strategy Message-ID: In-Reply-To: Patrick Steinhardt writes: > On Mon, Oct 27, 2025 at 08:53:22AM -0700, Junio C Hamano wrote: >> Patrick Steinhardt writes: >> >> > Changes in v4: >> > - Fix a flaky test because git-repack(1) always decides to rewrite the >> > MIDX, even though no packs have changed. This isn't a new issue, and >> > other maintenance tasks behave the same. So I decided to punt on it >> > for now. >> >> Thanks, but this round raced against 'next', so let me fabricate the >> following and queue it instead. > > Thanks for doing this! > >> ------- >8 ------- >> From: Patrick Steinhardt >> Date: Mon, 27 Oct 2025 09:30:50 +0100 >> Subject: [PATCH] t7900: fix a flaky test due to git-repack always regenerating .midx > > s/.midx/MIDX, as the MIDX file does not have a dot anywhere. > >> >> When a supposedly no-op "git repack" runs across a second boundary, >> because the command always touches the MIDX file and updates its >> timestamp, "ls -l $GIT_DIR/objects/pack/" before and after the >> operation can change, which causes such a test to fail. Only >> compare the *.pack files in the directory before and after the >> operation to work around this flakyness. > > Maybe add something like the following: > > Arguably, git-repack(1) should learn to not rewrite the MIDX in case > we know it is already up-to-date. But this is not a new problem > introduced via the new geometric maintenance task, so for now it > should be good enough to paper over the issue. Will add. Let me mark it for 'next' after squashing it in.