From: Junio C Hamano Date: Sun, 31 May 2026 00:46:35 GMT Subject: Re: [PATCH v2 2/2] status: improve rebase todo list parsing Message-ID: In-Reply-To: Phillip Wood writes: > +static void abbrev_oid_in_line(struct repository *r, > + struct strbuf *line, char **pp) > +{ > ... > + have_oid = !repo_get_oid(r, p, &oid); > + *end_of_object_name = saved; > + if (!have_oid) > + goto out; /* object name was a label */ Can there be a label "deadbeef123" that is unrelated to an object whose object name happens to abbreviate to "deadbeef123"? > + case TODO_MERGE: > + skip_dash_c(&p); > + while (true) { > + p += strspn(p, " \t"); > + if (!p[0] || (p[0] == '#' && (!p[1] || isspace(p[1])))) > + break; > + abbrev_oid_in_line(r, line, &p); > + } > + break; What does this loop do? A "merge" command may look like "merge [[-C|-c] ]