From: Junio C Hamano Date: Sun, 21 Jun 2026 20:28:29 GMT Subject: Re: [PATCH v3 0/2] completion: hide dotfiles for selected path completion Message-ID: In-Reply-To: "D. Ben Knoble" writes: > [Small typo correction that may affect how the message is read] Thanks, I spotted another one. >> ... I find this range diff very troubling. If we look at patch 2, >> it seems that it redoes some part of what is done in patch 1 saying >> "oops that was wrong, so let's do it better this time". Such a >> drunken-mans' walk that goes in one direction in an earlier step, >> only to be corrected to move to a different course, is now how we > > "is not" :) True. >> want a new topic to be presented. >> >> The end result may be much easier to read, mostly thanks to updated >> loop in the awk script, so if we really want to pretend this as two "pretend" -> "present". >> patches for "small pieces are easier to digest" value, perhaps have >> [PATCH 1/2] that updates the awk script (without doing anything >> related to hide-dotfiles theme) to make it easier to read by not >> having multiple "print pfx p" in it, and then build on top of that >> improved base, have [PATCH 2/2] that adds the support to hide >> dotfiles, perhaps?